Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement sequencer api with mysql #605

Merged
merged 37 commits into from
Jul 18, 2022
Merged

feat: implement sequencer api with mysql #605

merged 37 commits into from
Jul 18, 2022

Conversation

GimmeCyy
Copy link
Contributor

@GimmeCyy GimmeCyy commented May 25, 2022 •
edited by seeflood
Loading

What this PR does:
add sequencer api component by mysql

Which issue(s) this PR fixes:
Fixes #489

@seeflood
Copy link
Member

seeflood commented May 27, 2022 •
edited
Loading

Thanks!
To fix the CI error, you can make format and then git commit the changes

@ZLBer
Copy link
Member

ZLBer commented May 29, 2022

@GimmeCyy I answered you below #509

@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #605 (1f61009) into main (917485d) will decrease coverage by 0.03%.
The diff coverage is 58.40%.

❗ Current head 1f61009 differs from pull request most recent head 070be20. Consider uploading reports for the commit 070be20 to get more accurate results

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   60.62%   60.58%   -0.04%     
==========================================
  Files         125      127       +2     
  Lines        6539     6652     +113     
==========================================
+ Hits         3964     4030      +66     
- Misses       2195     2235      +40     
- Partials      380      387       +7
Impacted Files Coverage Δ
components/pkg/utils/mysql.go 0.00% <0.00%> (ø)
components/sequencer/mysql/mysql.go 76.74% <76.74%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917485d...070be20. Read the comment docs.

ZLBer
ZLBer previously approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@ZLBer ZLBer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally add some docs below docs/en/component_specs/sequencer docs/zh/component_specs/sequencer

seeflood
seeflood requested changes Jun 3, 2022
View reviewed changes
cmd/layotto/main.go Show resolved Hide resolved
@ZLBer
Copy link
Member

ZLBer commented Jun 12, 2022

@GimmeCyy 本地的锁似乎是没用的，layotto可能是多机部署。可以先交流下再写代码~

ZLBer
ZLBer previously approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@ZLBer ZLBer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood mentioned this pull request Jun 22, 2022
Closed
@seeflood seeflood self-assigned this Jul 3, 2022
seeflood
seeflood approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@seeflood seeflood merged commit 2604d62 into mosn:main Jul 18, 2022
@seeflood
Copy link
Member

@GimmeCyy Thanks for your help!

@ZLBer ZLBer mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenjunMa zhenjunMa zhenjunMa approved these changes

@seeflood seeflood seeflood approved these changes

@ZLBer ZLBer ZLBer left review comments

Assignees

@seeflood seeflood

Labels
area/component cla:yes size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Sequencer API component: mysql
6 participants
@GimmeCyy @seeflood @ZLBer @zhenjunMa @wenxuwan @Xunzhuo